small changes

Author: bkap123

Lib/test/test_functools.py

@@ -514,7 +514,7 @@ def test_partial_genericalias(self):
         self.assertEqual(alias.__args__, (int,))
         self.assertEqual(alias.__parameters__, ())
 
-    # Issue 144475
+    # GH-144475: Tests that the partial object does not change until repr finishes
     def test_repr_saftey_against_reentrant_mutation(self):
         g_partial = None
 

Misc/NEWS.d/next/C_API/2026-02-07-16-37-42.gh-issue-144475.8tFEXw.rst

@@ -1,6 +1,3 @@
-Fixed a bug in :func:`functools.partial` when calling :func:`repr` on a partial
-object that could occur when the ``fn``, ``args``, or ``kw`` arguments are modified
-during a call to :func:`repr`. Now, calls to :func:`repr` will use the original
-arguments when generating the string representation of the partial object.
-Subsequent calls will use the updated arguments instead.
-
+Calling :func:`repr` on :func:`functools.partial` will no longer
+use a mutated version of the arguments ``fn``, ``args``, or ``kw``
+when generating the string representation of the partial object.

Modules/_functoolsmodule.c

@@ -689,9 +689,9 @@ partial_repr(PyObject *self)
     partialobject *pto = partialobject_CAST(self);
     PyObject *result = NULL;
     PyObject *fn, *args, *kw;
-    PyObject *arglist;
-    PyObject *mod;
-    PyObject *name;
+    PyObject *arglist = NULL;
+    PyObject *mod = NULL;
+    PyObject *name = NULL;
     Py_ssize_t i, n;
     PyObject *key, *value;
     int status;
@@ -712,15 +712,15 @@ partial_repr(PyObject *self)
 
     arglist = Py_GetConstant(Py_CONSTANT_EMPTY_STR);
     if (arglist == NULL) {
-        goto arglist_error;
+        goto done;
     }
     /* Pack positional arguments */
     n = PyTuple_GET_SIZE(args);
     for (i = 0; i < n; i++) {
         Py_SETREF(arglist, PyUnicode_FromFormat("%U, %R", arglist,
                                         PyTuple_GET_ITEM(args, i)));
         if (arglist == NULL) {
-            goto arglist_error;
+            goto done;
         }
     }
     /* Pack keyword arguments */
@@ -731,27 +731,25 @@ partial_repr(PyObject *self)
                                                 key, value));
         Py_DECREF(value);
         if (arglist == NULL) {
-            goto arglist_error;
+            goto done;
         }
     }
 
     mod = PyType_GetModuleName(Py_TYPE(pto));
     if (mod == NULL) {
-        goto mod_error;
+        goto done;
     }
 
     name = PyType_GetQualName(Py_TYPE(pto));
     if (name == NULL) {
-        goto name_error;
+        goto done;
     }
 
     result = PyUnicode_FromFormat("%S.%S(%R%U)", mod, name, fn, arglist);
-    Py_DECREF(name);
- name_error:
-    Py_DECREF(mod);
- mod_error:
-    Py_DECREF(arglist);
- arglist_error:
+done:
+    Py_XDECREF(name);
+    Py_XDECREF(mod);
+    Py_XDECREF(arglist);
     Py_DECREF(fn);
     Py_DECREF(args);
     Py_DECREF(kw);