You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Summary: Rename and significantly enhance the quality gate status tool from get_project_quality_gate_status to check_quality_gate_status, making projectKey required while adding intelligent failure details (coverage, issues, hotspots, duplications, dependencies) and a basicReport mode for simpler output.
Review Focus:
The substantial logic added to ProjectStatusTool.java (400+ lines) that fetches and aggregates data from multiple APIs (measures, issues, hotspots, SCA) when quality gates fail. Pay close attention to error handling in buildFailureDetails() methods—they catch exceptions broadly, which could mask real issues.
Parameter changes: inNewCodePeriod added to IssuesApi.SearchParams with special handling using componentKeys instead of projects when filtering new code—verify this API contract is correct.
The response schema overhaul in ProjectStatusToolResponse.java with many new nested records; ensure JSON serialization aligns with the test expectations.
Start review at: ProjectStatusTool.java. This is the core of the change—it orchestrates the new detailed failure reporting and drives all other modifications. The complexity here determines whether the feature works correctly and performs acceptably.
Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nquinquenel
force-pushed
the
feature/nq/MCP-295-enhance-qg-tool
branch
from
No description provided.