Fix on redundant pull request constraints#3713
Open
brandonlam2030 wants to merge 2 commits intochaoss:mainfrom
Open
Fix on redundant pull request constraints#3713brandonlam2030 wants to merge 2 commits intochaoss:mainfrom
brandonlam2030 wants to merge 2 commits intochaoss:mainfrom
Conversation
Signed-off-by: Brandon Lam <brandonlam2030@gmail.com>
brandonlam2030
force-pushed
the
Redundant_Argument_Fixes
branch
from
ec71f0c to
c885014
Compare
Contributor
|
look good! i will generate a database migration script based on this (the process is still being worked out and isnt the most newcomer-friendly yet). Thanks for the contribution! |
MoralCode
added
the
pending changes
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
MoralCode
added
database
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Pull Request model contains redundant checks on unique data. Since two table arguments perform the same checks on repo_id and pr_src_id, we can remove one to improve efficiency. This removes unnecessary database overhead by eliminating duplicate constraints.
This PR fixes #3712
Notes for Reviewers
Signed commits