lint: remove invalid type annotation in repo_load_controller#3745
Open
DhaneshKolu wants to merge 2 commits intochaoss:mainfrom
Open
lint: remove invalid type annotation in repo_load_controller#3745DhaneshKolu wants to merge 2 commits intochaoss:mainfrom
DhaneshKolu wants to merge 2 commits intochaoss:mainfrom
Conversation
…oller Signed-off-by: Dhanesh Kolu <your-github-email@example.com>
Contributor
Author
|
@MoralCode |
shlokgilda
requested changes
Feb 28, 2026
Collaborator
shlokgilda
left a comment
shlokgilda
left a comment
There was a problem hiding this comment.
The intention is good but incorrect implementation.
augur/util/repo_load_controller.py
Outdated
|
|
||
| # Find the column named in the 'order_by', and get its asc() or desc() method | ||
| directive: function = getattr(get_colum_by_label(order_by), direction.lower()) | ||
| directive: getattr(get_colum_by_label(order_by), direction.lower()) |
Collaborator
There was a problem hiding this comment.
Remove the bogus ":" from the code.
Suggested change
| directive: getattr(get_colum_by_label(order_by), direction.lower()) | |
| directive = getattr(get_colum_by_label(order_by), direction.lower()) |
Contributor
Author
There was a problem hiding this comment.
yeah thanks for pointing out
…oller Signed-off-by: Dhanesh Kolu <koludhanesh5@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes invalid type annotation (function) that caused pylint E0602 (undefined-variable).
No functional behavior change.
Lint and tests pass locally.