src: remove redundant experimental_transform_types from node_options.h#62058
Open
ShenHongFei wants to merge 1 commit intonodejs:mainfrom
Open
src: remove redundant experimental_transform_types from node_options.h#62058ShenHongFei wants to merge 1 commit intonodejs:mainfrom
experimental_transform_types from node_options.h#62058ShenHongFei wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
marco-ippolito
approved these changes
Mar 1, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62058 +/- ##
==========================================
+ Coverage 89.58% 89.65% +0.07%
==========================================
Files 674 676 +2
Lines 205159 206239 +1080
Branches 39352 39496 +144
==========================================
+ Hits 183792 184908 +1116
+ Misses 13583 13460 -123
- Partials 7784 7871 +87
🚀 New features to boost your workflow:
|
Renegade334
approved these changes
Mar 1, 2026
cjihrig
approved these changes
Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#61803 removed --experimental-transform-types
There is still one related attribute in node_options.h that has not been removed.
@marco-ippolito