Skip to content

src: remove redundant experimental_transform_types from node_options.h#62058

Open
ShenHongFei wants to merge 1 commit intonodejs:mainfrom
ShenHongFei:fix-redundant-transform-types
Open

src: remove redundant experimental_transform_types from node_options.h#62058
ShenHongFei wants to merge 1 commit intonodejs:mainfrom
ShenHongFei:fix-redundant-transform-types

Conversation

@ShenHongFei
Copy link
Contributor

#61803 removed --experimental-transform-types

There is still one related attribute in node_options.h that has not been removed.

@marco-ippolito

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/config

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. config Issues or PRs related to the config subsystem needs-ci PRs that need a full CI run. labels Mar 1, 2026
@codecov
Copy link

codecov bot commented Mar 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.65%. Comparing base (6a3d358) to head (340575f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62058      +/-   ##
==========================================
+ Coverage   89.58%   89.65%   +0.07%     
==========================================
  Files         674      676       +2     
  Lines      205159   206239    +1080     
  Branches    39352    39496     +144     
==========================================
+ Hits       183792   184908    +1116     
+ Misses      13583    13460     -123     
- Partials     7784     7871      +87     
Files with missing lines Coverage Δ
src/node_options.h 97.93% <ø> (+0.03%) ⬆️

... and 123 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Renegade334 Renegade334 added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v25.x PRs that should not land on the v25.x-staging branch and should not be released in v25.x. labels Mar 1, 2026
@Renegade334 Renegade334 added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. config Issues or PRs related to the config subsystem dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v25.x PRs that should not land on the v25.x-staging branch and should not be released in v25.x. needs-ci PRs that need a full CI run. request-ci Add this label to start a Jenkins CI on a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants