distrodefs: add cache for decoded YAML files#2161
Draft
lzap wants to merge 1 commit intoosbuild:mainfrom
Draft
Conversation
This cache is unique for each filesystem (it can be mocked in tests) and for each value type. Each returned value is a deep copy of the cached prototype. This significantly speeds up loading of oses and image types. It speeds up the "ibcli list" from 4s to 0.6s.
Member
In that case, I hope you don't mind, I'll mark it as draft. |
supakeen
reviewed
Feb 25, 2026
Member
supakeen
left a comment
supakeen
left a comment
There was a problem hiding this comment.
Need to comment to get this out of my queue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cache is unique for each filesystem (it can be mocked in tests) and for each value type. Each returned value is a deep copy of the cached prototype. This significantly speeds up loading of oses and image types. It speeds up the "ibcli list" from 4s to 0.6s.
This is nicer implementation that I created in the morning, I am just pushing it here so I will not forget to take a look later. This is not meant to be merged yet.