gh-144411: Validate slotstate type in pickle.load_build()

[Krishna-web-hub]

• This fixes the slotstate issue for an object’s __slots__ saved during pickling.
• This also fixes the difference in slotstate behavior in pickle.py and _pickle.c .
• Added the NEWS file.

• Issue: Pickle load_build function checks if slotstate is False, not a dict #144411

[da-woods]

I don't think this actually makes the C and Python implementations equivalent. What happens if slotstate is provided but is None?

[Krishna-web-hub]

Hi @da-woods, if slotstate is none , then there are no __slots__ to restore ,so unpickling skips slot restoration. matching the behavior of __pickle.c.

[ZeroIntensity]

I think something went wrong during the rebase?

[bedevere-app]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

[Krishna-web-hub]

@ZeroIntensity ,I have made the requested changes; Please review again

[bedevere-app]

Thanks for making the requested changes!

@ZeroIntensity: please review the changes made to this pull request.