Conformance suite: rewrite directives_version_platform.py to not assume that type checkers will ignore all errors in unreachable code#2202
Open
AlexWaygood wants to merge 1 commit intomainfrom
Conversation
…sume that type checkers will ignore all errors in unreachable code
AlexWaygood
added
the
topic: conformance tests
AlexWaygood
requested review from
JelleZijlstra,
JukkaL,
carljm,
erictraut and
rchen152
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The typing spec states:
ty does! However, it currently fails 100% of the assertions in
conformance/tests/directives_version_platform.py, because it attempts to provide some type checking of code even if that code is in a region deemed to be unreachable. All the assertions in this file currently assume that a good way to test whether a type checker understandssys.version_infoorsys.platformchecks is to assert that they will emit no errors for obviously incorrect code in unreachable branches. But as far as I know, this is not described anywhere as a requirement for spec-conformant type checkers.This PR rewrites the tests in this file so that they still assert that type checkers properly understand simple version and platform checks, but so that they no longer assume that type checkers will silence all errors in regions of code that they deem to be unreachable. With these changes, ty passes 100% of the assertions in this file. The conformance score of all other type checkers on this file is unchanged.