Migrate app_proxy spec to deployConfig + transformRemoteToLocal#6913
Migrate app_proxy spec to deployConfig + transformRemoteToLocal#6913ryancbahan wants to merge 1 commit intorcb/contract-app-accessfrom
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
ryancbahan
force-pushed
the
rcb/contract-app-proxy
branch
from
bc115a4 to
c53aa70
Compare
ryancbahan
force-pushed
the
rcb/contract-app-access
branch
from
34af0cc to
6d74a10
Compare
|
🤖 Code Review · #projects-dev-ai for questions ✅ Complete - 2 findings 📋 History✅ No issues → ✅ 2 findings |
ryancbahan
force-pushed
the
rcb/contract-app-access
branch
from
6d74a10 to
8a440ce
Compare
ryancbahan
force-pushed
the
rcb/contract-app-proxy
branch
2 times, most recently
from
d7de3ae to
7d785eb
Compare
ryancbahan
force-pushed
the
rcb/contract-app-access
branch
from
8a440ce to
9b654f8
Compare
Coverage report
Test suite run success3780 tests passing in 1449 suites. Report generated by 🧪jest coverage report action from 6f5cf55 |
![binks-code-reviewer[bot]](https://avatars.githubusercontent.com/in/2788732?s=60&v=4){kind=small}
| @@ -55,12 +42,6 @@ const AppProxyTransformConfig: CustomTransformationConfig = { | |||
| }, | |||
| } | |||
There was a problem hiding this comment.
transformRemoteToLocal can emit invalid local config when remote content is partial/empty
transformRemoteToLocal assumes the remote payload always contains {url, subpath, prefix} and immediately dereferences proxyConfig.url / .subpath / .prefix. If the server returns {} (or omits one of these fields during rollout/migration, or for older apps), this function can return { app_proxy: { url: removeTrailingSlash(undefined), subpath: undefined, prefix: undefined } }, which may throw at runtime (depending on removeTrailingSlash) or silently write invalid config that later fails validation or breaks proxy routing.
| deployConfig: async (config) => { | ||
| const {name, ...rest} = configWithoutFirstClassFields(config) | ||
| return rest | ||
| }, |
There was a problem hiding this comment.
Behavior change: relative app_proxy.url is no longer resolved against application_url
The PR removes the forward transform that previously applied prependApplicationUrl when app_proxy.url was relative, and tests covering that behavior were removed. The CLI now sends app_proxy.url as-is via deployConfig. If local config uses a relative path (e.g. "/api/proxy"), that relative value will now be sent to the server; if server-side resolution is not fully rolled out or differs from prior CLI join semantics (e.g., trailing slashes), proxies may deploy with an invalid/incorrect URL.
ryancbahan
force-pushed
the
rcb/contract-app-access
branch
from
9b654f8 to
cbf520a
Compare
ryancbahan
force-pushed
the
rcb/contract-app-proxy
branch
from
7d785eb to
aa09ed5
Compare
Remove transformConfig including prependApplicationUrl forward logic. Set deployConfig (configWithoutFirstClassFields pass-through) and transformRemoteToLocal directly (flat url/prefix/subpath → nested app_proxy). transformLocalToRemote is now undefined — server handles URL resolution. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ryancbahan
force-pushed
the
rcb/contract-app-access
branch
from
cbf520a to
7d1020a
Compare
ryancbahan
force-pushed
the
rcb/contract-app-proxy
branch
from
aa09ed5 to
6f5cf55
Compare
1 participant
Summary
transformConfigfrom app_proxy spec, includingprependApplicationUrlforward logicdeployConfigandtransformRemoteToLocaldirectly (flaturl/prefix/subpath→ nestedapp_proxy)transformLocalToRemoteis nowundefined— server handles URL resolutionTest plan
getDevSessionUpdateMessagestests pass🤖 Generated with Claude Code