Skip to content

Migrate webhook_subscription spec to direct transform parameters#6915

Open
ryancbahan wants to merge 1 commit intorcb/contract-privacy-compliancefrom
rcb/contract-webhook-subscription
Open

Migrate webhook_subscription spec to direct transform parameters#6915
ryancbahan wants to merge 1 commit intorcb/contract-privacy-compliancefrom
rcb/contract-webhook-subscription

Conversation

@ryancbahan
Copy link
Contributor

@ryancbahan ryancbahan commented Feb 28, 2026

Summary

  • Replace CustomTransformationConfig wrapper with direct deployConfig, transformLocalToRemote, and transformRemoteToLocal parameters
  • No behavior change — forward transform (URI resolution via prependApplicationUrl) and reverse transform both preserved as-is
  • Phase A formalization: makes the transforms explicit and separates deploy config from transform logic
  • Part of the app module contracts migration

Test plan

  • Both existing tests pass unchanged (reverse transform + forward transform with URI resolution)

🤖 Generated with Claude Code

@ryancbahan ryancbahan marked this pull request as ready for review February 28, 2026 02:19
@ryancbahan ryancbahan requested a review from a team as a code owner February 28, 2026 02:19
@github-actions
Copy link
Contributor

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

@ryancbahan ryancbahan force-pushed the rcb/contract-webhook-subscription branch from a5bce51 to deb40dc Compare February 28, 2026 02:47
@ryancbahan ryancbahan force-pushed the rcb/contract-privacy-compliance branch from 00011a6 to 396e80d Compare February 28, 2026 02:47
@binks-code-reviewer
Copy link

🤖 Code Review · #projects-dev-ai for questions
React with 👍/👎 or reply — all feedback helps improve the agent.

Complete - No issues

📋 History

✅ No issues

@ryancbahan ryancbahan force-pushed the rcb/contract-privacy-compliance branch from 396e80d to c7f0a8f Compare February 28, 2026 14:42
@ryancbahan ryancbahan force-pushed the rcb/contract-webhook-subscription branch from deb40dc to 3d52eab Compare February 28, 2026 14:42
@ryancbahan ryancbahan force-pushed the rcb/contract-privacy-compliance branch from c7f0a8f to c0af9b7 Compare February 28, 2026 14:46
@ryancbahan ryancbahan force-pushed the rcb/contract-webhook-subscription branch from 3d52eab to 2887d33 Compare February 28, 2026 14:46
@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2026

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 78.84% 14544/18448
🟡 Branches 73.11% 7229/9888
🟡 Functions 79.05% 3698/4678
🟡 Lines 79.17% 13744/17360

Test suite run success

3780 tests passing in 1449 suites.

Report generated by 🧪jest coverage report action from e2bfb10

@ryancbahan ryancbahan force-pushed the rcb/contract-privacy-compliance branch from c0af9b7 to 9c3310a Compare February 28, 2026 20:16
@ryancbahan ryancbahan force-pushed the rcb/contract-webhook-subscription branch from 2887d33 to 28467df Compare February 28, 2026 20:16
Replace transformConfig wrapper with deployConfig, transformLocalToRemote,
and transformRemoteToLocal set directly. No behavior change — forward
transform (URI resolution) and reverse transform preserved as-is.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@ryancbahan ryancbahan force-pushed the rcb/contract-webhook-subscription branch from 28467df to e2bfb10 Compare February 28, 2026 20:50
@ryancbahan ryancbahan force-pushed the rcb/contract-privacy-compliance branch from 9c3310a to 1e28d1e Compare February 28, 2026 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant